Skip to content

Conversation

@mathiasbynens
Copy link
Member

@mathiasbynens mathiasbynens requested a review from a team as a code owner September 10, 2025 05:38
@mathiasbynens
Copy link
Member Author

The test failures are expected, at least until engines update their Unicode data to v17.

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rubber-stamp as usual.

@ptomato
Copy link
Contributor

ptomato commented Sep 17, 2025

We talked in the maintainers meeting and think the right time frame for merging this is 1 month after CLDR 48 is released.

@linusg
Copy link
Member

linusg commented Oct 27, 2025

They didn't do a timely update of the release notes which still say beta draft but the final version of CLDR 48 was released on October 23: https://github.com/unicode-org/cldr/releases/tag/release-48

@linusg
Copy link
Member

linusg commented Nov 24, 2025

A month has passed so this and #4572 can be merged.

Additionally I'd like to point out that there's a circular dependency here - engines might not want to update their version of CLDR before relevant tests have landed, e.g. quickjs-ng/quickjs#1168. Perhaps it makes sense to treat this similar to stage 2.7 and merge tests before asking implementations to update in the future.

@mathiasbynens
Copy link
Member Author

Additionally I'd like to point out that there's a circular dependency here - engines might not want to update their version of CLDR before relevant tests have landed, e.g. quickjs-ng/quickjs#1168. Perhaps it makes sense to treat this similar to stage 2.7 and merge tests before asking implementations to update in the future.

+1 to this. In the past, we landed these updated tests as soon as they became available, and IMHO we should get back to that.

@ptomato ptomato force-pushed the unicode-17-identifiers branch from cd1c50c to 4e70779 Compare November 25, 2025 20:21
@ptomato
Copy link
Contributor

ptomato commented Nov 25, 2025

I'm assuming the ESMeta test failures are because of ESMeta not having updated Unicode data.

@ptomato ptomato merged commit 27d7962 into tc39:main Nov 25, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants